From: Marco Trevisan (Treviño) <mail@3v1n0.net>
Date: Mon, 28 May 2018 23:28:26 +0000 (+0300)
Subject: st-label: Unset clutter text instance on disposal
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~929^2~5^2~51
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=44894262f49b9f8b2809321ebcf1cd9426303fd6;p=gnome-shell.git

st-label: Unset clutter text instance on disposal

The instance is owned by the actor (being its child), and thus when the
disposal happens for the parent the text is disposed too, thus it's just
safer to nullify its reference so that we won't try to access to invalid
objects later, and this might be the case since the JS objects could be kept
around until they aren't finalized.

https://bugzilla.gnome.org/show_bug.cgi?id=788931
---

diff --git a/src/st/st-label.c b/src/st/st-label.c
index a7893b074..515e34323 100644
--- a/src/st/st-label.c
+++ b/src/st/st-label.c
@@ -180,6 +180,7 @@ st_label_dispose (GObject   *object)
 {
   StLabelPrivate *priv = ST_LABEL (object)->priv;
 
+  priv->label = NULL;
   g_clear_pointer (&priv->text_shadow_pipeline, cogl_object_unref);
 
   G_OBJECT_CLASS (st_label_parent_class)->dispose (object);